Bug in cleanUpPhenoData
2
0
Entering edit mode
flo • 0
@flo-11930
Last seen 8.1 years ago

cleanUpPhenoData in arrayQualitymetrics disregards the intgroup columns for phenodata structures with many columns.

This line (https://github.com/Bioconductor-mirror/arrayQualityMetrics/blob/master/R/prepdata.r#L245) does not take into account intgroup columns; it might if they have low enough indices though:

wh = wh[seq_len(maxcol)]

 

arrayQualityMetrics • 1.3k views
ADD COMMENT
0
Entering edit mode
flo • 0
@flo-11930
Last seen 8.1 years ago

One possible solution would be sth like the following, added on line 215, for example (https://github.com/Bioconductor-mirror/arrayQualityMetrics/blob/release-3.4/R/prepdata.r#L215):

newpd <- pd[, intgroup]
others <- setdiff(names(pd), intgroup)
pd <- cbind(newpd, pd[, others])

ADD COMMENT
0
Entering edit mode
@wolfgang-huber-3550
Last seen 3 months ago
EMBL European Molecular Biology Laborat…

Dear Flo

Thank you for the report and precise dissection of the problem.  This should be fixed in arrayQualityMetrics version 3.31.2 in the devel branch. (Thanks to Andrzej Oles for testing and completing my fixes!)

Wolfgang

ADD COMMENT

Login before adding your answer.

Traffic: 540 users visited in the last hour
Help About
FAQ
Access RSS
API
Stats

Use of this site constitutes acceptance of our User Agreement and Privacy Policy.

Powered by the version 2.3.6